Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $ensure parameter for all package operations #216

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Jul 29, 2024

Pull Request (PR) description

Adds the $ensure parameter to handle which version will be installed. This is useful to install a specific version, but may also be used to upgrade to a newer version.

This Pull Request (PR) fixes the following issues

none

@fraenki
Copy link
Member Author

fraenki commented Jan 3, 2025

@smortex Could you probably review this PR too? 😊

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module has currently some poor data types unfortunately. I added an in-line note to avoid introducing more.

FYI, I have a branch with a bunch of data types improvements (improve-data-types, #193) and is not merged yet because it lacks review 😭. If you agree with these changes, feel free to rebase your commit on top of this branch so that we can merge all improvements at once 😉

manifests/client.pp Outdated Show resolved Hide resolved
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@smortex smortex merged commit 904a361 into voxpupuli:master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants